-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Implement Factoring → ILP reduction (issue #21) #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
388d761
docs: Add design document for Factoring to ILP reduction
GiggleLiu fce3612
docs: Add code example for Factoring → ILP reduction
GiggleLiu a8123a6
test: Add step-by-step comments to factor_15 test
GiggleLiu 3a6850a
feat: Integrate Factoring → ILP into reduction graph
GiggleLiu d127c0e
fix: Address PR review comments
GiggleLiu 345f5b2
fix: Make reduction graph JSON export deterministic
GiggleLiu 0f5f543
refactor: Remove redundant add_edge for Factoring→ILP
GiggleLiu dbbfb13
refactor: Remove all redundant manual add_edge! calls
GiggleLiu 523666e
refactor: Remove empty register_reductions function
GiggleLiu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example uses
ILP/ILPSolver, which are behind the crate’silpfeature. Consider noting in the paper snippet that consumers must enable theilpfeature (e.g., inCargo.tomlor via--features ilp), otherwise this example won’t compile when copied.