Fix crash when lyrics startBar is over bars length#439
Merged
Danielku15 merged 2 commits intoCoderLine:developfrom Nov 27, 2020
thoun:patch-2
Merged
Fix crash when lyrics startBar is over bars length#439Danielku15 merged 2 commits intoCoderLine:developfrom thoun:patch-2
Danielku15 merged 2 commits intoCoderLine:developfrom
thoun:patch-2
Conversation
Member
|
Usually a PRs should be related to a work item tracked via issues. For the future please be sure to create a bug/feature-request and refer to it in the PR. The fix seems valid. It seems this file is either corrupt or GP allows specifying bars beyond the range which is valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading that file, alphaTab crash because lyrics is at bar 126 but there's only 108 bars. With the fix, lyrics placed after last bar is ignored.
The Cranberries - Zombie (ver 7 by kartapus).zip