Skip to content

Update selection cursor when setting playbackRange. #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielku15 merged 2 commits into from
Oct 21, 2020
Merged

Update selection cursor when setting playbackRange. #419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bb4cda
Update selection cursor when setting playbackRange.
Danielku15 Oct 21, 2020
ea82bbe
Ensure selection is cleared
Danielku15 Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/AlphaTabApiBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,9 @@ export class AlphaTabApiBase<TSettings> {
public set playbackRange(value: PlaybackRange | null) {
if (this.player) {
this.player.playbackRange = value;
if (this.settings.player.enableCursor) {
this.updateSelectionCursor(value);
}
}
}

Expand Down Expand Up @@ -798,7 +801,7 @@ export class AlphaTabApiBase<TSettings> {
if (
nextBeatBoundings &&
nextBeatBoundings.barBounds.masterBarBounds.staveGroupBounds ===
barBoundings.staveGroupBounds
barBoundings.staveGroupBounds
) {
nextBeatX = nextBeatBoundings.visualBounds.x;
}
Expand Down Expand Up @@ -962,6 +965,24 @@ export class AlphaTabApiBase<TSettings> {
this._beatMouseDown = false;
}

private updateSelectionCursor(range: PlaybackRange | null) {
if (!this._tickCache) {
return;
}
if(range) {
const startBeat = this._tickCache.findBeat(this.tracks, range.startTick);
const endBeat = this._tickCache.findBeat(this.tracks, range.endTick);
if (startBeat && endBeat) {
const selectionStart = new SelectionInfo(startBeat.currentBeat);
const selectionEnd = new SelectionInfo(endBeat.currentBeat);
this.cursorSelectRange(selectionStart, selectionEnd);
}
} else {
this.cursorSelectRange(null, null);
}

}

private setupClickHandling(): void {
this.canvasElement.mouseDown.on(e => {
if (!e.isLeftMouseButton) {
Expand Down