fix: menu dropdown aria attribute #4020#4053
Merged
cristian-ungureanu merged 2 commits intodevelopmentfrom Aug 2, 2023
Merged
Conversation
Collaborator
Contributor
|
@preda-bogdan all good here 👍 |
HardeepAsrani
approved these changes
Jul 31, 2023
Collaborator
|
🎉 This PR is included in version 3.6.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
aria-labelon the dropdown of the sidebar menu.Will affect the visual aspect of the product
NO
Screenshots
Pic 1
Aria Label
Test instructions
Check before Pull Request is ready:
Closes #4020.