Merged
Conversation
c7f252d to
2ccf382
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive test to validate that all @MethodHook annotations in sanitizers reference existing classes and methods, while also fixing several typos and descriptor errors discovered by this validation.
- Introduces
HookBindingSanityTestto verify method hook annotations reference valid targets - Fixes multiple typos in method descriptors across sanitizer classes
- Corrects class name references and removes duplicate/invalid hooks
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| HookBindingSanityTest.java | New test class that validates method hook annotations against actual class/method existence |
| BUILD.bazel (test) | Adds build configuration for the new test with required dependencies |
| RegexRoadblocks.java | Fixes return type in method descriptor from CharPredicate to BmpCharPredicate |
| LdapInjection.kt | Corrects typos in method descriptors (namespace separator and parameter type) |
| FilePathTraversal.java | Fixes class name typo and removes duplicate method hook |
| BUILD.bazel (main) | Updates visibility to allow test access to sanitizer classes |
| maven_install.json | Adds new Maven dependencies required for testing |
| MODULE.bazel | Declares new Maven artifacts for Jakarta EL and JPA APIs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Marcono1234
reviewed
Oct 10, 2025
sanitizers/src/test/java/com/code_intelligence/jazzer/sanitizers/HookBindingSanityTest.java
Outdated
Show resolved
Hide resolved
sanitizers/src/test/java/com/code_intelligence/jazzer/sanitizers/HookBindingSanityTest.java
Outdated
Show resolved
Hide resolved
8511bfa to
909680c
Compare
oetr
approved these changes
Oct 15, 2025
Contributor
oetr
left a comment
There was a problem hiding this comment.
Awesome work, especially with the tests!
sanitizers/src/test/java/com/code_intelligence/jazzer/sanitizers/HookBindingSanityTest.java
Outdated
Show resolved
Hide resolved
sanitizers/src/test/java/com/code_intelligence/jazzer/sanitizers/HookBindingSanityTest.java
Outdated
Show resolved
Hide resolved
909680c to
b45d2eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to check that
MethodHookannotations in sanitizers reference existing classes & methods.