Fix: disable custom hooks during coverage report generation#1044
Open
Fix: disable custom hooks during coverage report generation#1044
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #878 where custom hooks are not properly disabled during coverage report generation, causing NoClassDefFoundError when hooked classes are used during coverage dumping and the hook class is no longer loadable.
Changes:
- Enable conditional hooks automatically when custom user hooks are used with coverage reporting
- Disable hooks before generating coverage reports in the shutdown sequence
- Add regression test to verify hooks are disabled during coverage report generation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/code_intelligence/jazzer/agent/Agent.kt | Automatically enables conditional hooks when user hooks are used with coverage reporting to allow runtime hook disabling |
| src/main/java/com/code_intelligence/jazzer/driver/FuzzTargetRunner.java | Disables hooks before coverage dump/report generation in shutdown sequence |
| src/main/java/com/code_intelligence/jazzer/driver/Opt.java | Updates comment to document that conditional hooks are used during coverage report generation |
| tests/src/test/java/com/example/CoverageWithHooksFuzzer.java | Regression test verifying hooks are disabled during coverage generation |
| tests/src/test/java/com/example/CoverageWithHooksFuzzerHooks.java | Custom hook for regression test that sets system property when called |
| tests/BUILD.bazel | Test configuration for the regression test with custom hook JAR |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4408889 to
ca199bd
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #878