Merged
Conversation
Contributor
bertschneider
left a comment
There was a problem hiding this comment.
Thank for the PR! It seems it's too small. 5 lines -> 5 comments, 500 lines -> LGTM 😅
Could you please add an integration test checking that the expected test names are actually printed?
e29c26d to
e6eb745
Compare
| if (process.env.JAZZER_LIST_FUZZTEST_NAMES) { | ||
| if ( | ||
| process.env.JAZZER_LIST_FUZZTEST_NAMES_PATTERN == undefined || | ||
| full_name.match(process.env.JAZZER_LIST_FUZZTEST_NAMES_PATTERN) |
Check failure
Code scanning / CodeQL
Regular expression injection
e6eb745 to
6c30c36
Compare
bertschneider
approved these changes
Sep 27, 2023
Contributor
bertschneider
left a comment
There was a problem hiding this comment.
Looks good, thx!
Come to think of it, this breaks with our plan to support all settings via environment variables, CLI parameters and configuration file entries. As it's a quite specific use-case IMHO it's ok to only support env vars here.
… set Futhermore will filter the list by regex if 'JAZZER_LIST_FUZZTEST_NAMES_PATTERN' is set.
6c30c36 to
d79d871
Compare
karfau
referenced
this pull request
in xmldom/xmldom
Oct 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@jazzer.js/core](https://togithub.com/CodeIntelligenceTesting/jazzer.js) | [`2.0.0` -> `2.1.0`](https://renovatebot.com/diffs/npm/@jazzer.js%2fcore/2.0.0/2.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>CodeIntelligenceTesting/jazzer.js (@​jazzer.js/core)</summary> ### [`v2.1.0`](https://togithub.com/CodeIntelligenceTesting/jazzer.js/releases/tag/v2.1.0): Release 2.1.0 [Compare Source](https://togithub.com/CodeIntelligenceTesting/jazzer.js/compare/v2.0.0...v2.1.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - **Feature**: Jest support: List fuzz test names by [@​zgtm](https://togithub.com/zgtm) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/606](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/606) - **Feature**: Handle real segfaults in fuzz targets by [@​br-lewis](https://togithub.com/br-lewis) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/602](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/602) - **Feature**: Provide consistent exit codes by [@​bertschneider](https://togithub.com/bertschneider) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/617](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/617) - **Bugfix**: Patch coverage of implicit else branches by [@​bertschneider](https://togithub.com/bertschneider) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/635](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/635) **Full Changelog**: CodeIntelligenceTesting/jazzer.js@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/xmldom/xmldom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
karfau
referenced
this pull request
in xmldom/xmldom
Oct 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@jazzer.js/jest-runner](https://togithub.com/CodeIntelligenceTesting/jazzer.js) | [`2.0.0` -> `2.1.0`](https://renovatebot.com/diffs/npm/@jazzer.js%2fjest-runner/2.0.0/2.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>CodeIntelligenceTesting/jazzer.js (@​jazzer.js/jest-runner)</summary> ### [`v2.1.0`](https://togithub.com/CodeIntelligenceTesting/jazzer.js/releases/tag/v2.1.0): Release 2.1.0 [Compare Source](https://togithub.com/CodeIntelligenceTesting/jazzer.js/compare/v2.0.0...v2.1.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - **Feature**: Jest support: List fuzz test names by [@​zgtm](https://togithub.com/zgtm) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/606](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/606) - **Feature**: Handle real segfaults in fuzz targets by [@​br-lewis](https://togithub.com/br-lewis) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/602](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/602) - **Feature**: Provide consistent exit codes by [@​bertschneider](https://togithub.com/bertschneider) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/617](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/617) - **Bugfix**: Patch coverage of implicit else branches by [@​bertschneider](https://togithub.com/bertschneider) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/635](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/635) **Full Changelog**: CodeIntelligenceTesting/jazzer.js@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/xmldom/xmldom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lists fuzz test names if
JAZZER_LIST_FUZZTEST_NAMESis set. Futhermore, will filter the list by regex ifJAZZER_LIST_FUZZTEST_NAMES_PATTERNis set.