Skip to content

bugfix: prevent endless loop when consuming an array of strings #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oetr merged 2 commits into from
Jul 31, 2023
Merged

bugfix: prevent endless loop when consuming an array of strings #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
655b123
bugfix: prevent endless loop when consuming an array of strings
oetr Jul 28, 2023
bc19dcf
Merge branch 'main' into bugfix_prevent_endless_loop
oetr Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/FuzzedDataProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,11 @@ describe("FuzzedDataProvider checks", () => {
expect(strings).toContain("m dol");
expect(strings).toContain("or si");
expect(strings).toContain("t ame");
const moreStrings = data.consumeStringArray(5, 0);
expect(moreStrings).toHaveLength(5);
for (const str of moreStrings) {
expect(str).toHaveLength(0);
}
});
it("verifyPrintableString", () => {
const data = new FuzzedDataProvider(Buffer.from(Data));
Expand Down
2 changes: 1 addition & 1 deletion packages/core/FuzzedDataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ export class FuzzedDataProvider {
const strs = [];
while (strs.length < maxArrayLength && this.remainingBytes > 0) {
const str = this.consumeString(maxStringLength, encoding, printable);
if (str) {
if (str || str === "") {
strs.push(str);
}
}
Expand Down