Conversation
oetr
reviewed
Jul 27, 2023
oetr
reviewed
Jul 31, 2023
Contributor
oetr
left a comment
There was a problem hiding this comment.
Great addition, thanks! Just minor nipicks from my side.
package-jazzer-js.sh and the github action would both run `npm install` which isn't necessary
bertschneider
approved these changes
Aug 1, 2023
Contributor
bertschneider
left a comment
There was a problem hiding this comment.
Looks good! Just minor suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test to the release pipeline after the release has been created. It will run a duplicate of
examples/jest_typescript_integrationexcept with thejest-runnerdependency is set to pull from npm rather than a local file reference.