Switch to fixed number of runs in flaky promise test#330
Merged
bertschneider merged 1 commit intomainfrom Feb 20, 2023
Merged
Conversation
The now given seed failed in CI after 60s, regardless of the low number of required iterations (425 on my system), even though the time should be enough. A few random runs resulted in required iterations lower 3k (on my system), so that 5k should be way enough with the fixed seed.
2332fc2 to
91b4586
Compare
0xricksanchez
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The now given seed failed in CI after 60s, regardless of the low number
of required iterations (425 on my system), even though the time should
be enough. A few random runs resulted in required iterations lower
3k (on my system), so that 5k should be way enough with the fixed
seed.