Closed
Conversation
e1a1dcf to
5376a9c
Compare
This allows the tests to actually run something when not in fuzzing mode
Contributor
Author
|
The CI tests revealed that this change will break code coverage for Javascript and fixing that will require a much larger change than expected. So we're going to close this for now until we can fix it properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for Jest tests that are written in Typescript along with an example of how that would look.
The primary change is in
packages/jest-runner/worker.tswhere we swapped out our own call toimportwith a call to Jest's transformer functionality which can (viats-jest) load Typescript files and convert them to Javascript before being put through jazzer.js's instrumentor.One change that I'm not sure about is
packages/jest-runner/jest-extension.tswhere I modify Jest'sItinterface to allow ourfuzz.tsfiles to pass the type checker but this requires importingjest-extensionin every test file. If anyone knows a better way to handle this, that'd be great.