Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

No description provided.

v3 was the action version of the previous base job.
We want to do changes one by one, and v4 (current main) does not work
without the concurrency change. This just brings the concurrency change
that we will need to set the action version to the latest (v4) again.
Enables perf by default on walltime runs, and requires explicit mode.
These flags will be tweaked in the PR adding proper perf management.
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 26, 2025

CodSpeed WallTime Performance Report

Merging #59 will degrade performances by 53.85%

Comparing just-add-root-frame (0167375) with main (81f0dc9)

Summary

❌ 18 regressions
✅ 26 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
switch 1 156 ns 312 ns -50%
switch 2 156 ns 312 ns -50%
test_iterative_fibo_10 216 ns 420 ns -48.57%
test_iterative_fibo_100 504 ns 696 ns -27.59%
test_recursive_cached_fibo_10 984 ns 1,188 ns -17.17%
test_recursive_cached_fibo_20 2.3 µs 2.5 µs -10.38%
test sync baz 10 156 ns 336 ns -53.57%
test sync baz 100 288 ns 456 ns -36.84%
test_iterative_fibo_10 228 ns 420 ns -45.71%
test_iterative_fibo_100 504 ns 684 ns -26.32%
test_recursive_cached_fibo_10 996 ns 1,152 ns -13.54%
test_recursive_cached_fibo_20 2.4 µs 2.7 µs -10.96%
test sync baz 10 168 ns 348 ns -51.72%
test sync baz 100 288 ns 480 ns -40%
switch 1 144 ns 312 ns -53.85%
switch 2 156 ns 300 ns -48%
switch 1 156 ns 276 ns -43.48%
switch 2 168 ns 300 ns -44%

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 26, 2025

CodSpeed Instrumentation Performance Report

Merging #59 will degrade performances by 45.38%

Comparing just-add-root-frame (0167375) with main (81f0dc9)

Summary

❌ 1 regression
✅ 81 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iterative_fibo_100 282.3 µs 516.8 µs -45.38%

@art049 art049 closed this Sep 26, 2025
@GuillaumeLagrange GuillaumeLagrange deleted the just-add-root-frame branch October 7, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants