Merged
Conversation
treigerm
commented
Jul 28, 2025
src/climatebenchpress/compressor/scripts/create_error_bounds.py
Outdated
Show resolved
Hide resolved
Collaborator
|
I’m ok with the change in error bounds and would be interested if the combined table, which also includes some bit information computations, also contains what you need. Perhaps @milankl can have a look at the math details here? |
Member
Author
|
At least for nitrogen dioxide there will be no match in the ERA5 variables which is why I had to resort to the computations from the BitInformation paper. |
Member
Author
milankl
approved these changes
Aug 5, 2025
milankl
reviewed
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #43 .
I would like to make some adjustments for which variables we use absolute and relative error bounds. There's a couple of reasons for this:
Let me know what you think @juntyr !