Refactor DynamicKey to use Supplier<IKey>#175
Merged
brachy84 merged 2 commits intoCleanroomMC:masterfrom Nov 25, 2025
Merged
Conversation
brachy84
requested changes
Nov 22, 2025
src/main/java/com/cleanroommc/modularui/drawable/text/DynamicKey.java
Outdated
Show resolved
Hide resolved
fix formatting issues
brachy84
approved these changes
Nov 25, 2025
brachy84
pushed a commit
to brachy84/ModularUI2-GTNH
that referenced
this pull request
Nov 27, 2025
* make DynamicKey take in IKeys instead of just string * don't return formatted text in get() fix formatting issues (cherry picked from commit 5046661)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactors DynamicKey to use a
Supplier<IKey>instead ofSupplier<String>add a new method
dynamicKey(Supplier<IKey>)to IKeyi could not name the method
dynamicas generic erasure would make it clash with theSupplier<String>methodalternatively i could just call it
key(Supplier<IKey>)or maybe
dynamic(Supplier<String>)could be renamed tostr(Supplier<String>)the old method would need to be kept for deprecation purposes, though