ISSDK-742: fix MoDisplayNames returns {Name} instead of actual values#174
Open
sagadira wants to merge 2 commits into
Open
ISSDK-742: fix MoDisplayNames returns {Name} instead of actual values#174sagadira wants to merge 2 commits into
sagadira wants to merge 2 commits into
Conversation
… - Add NonPublicSetterContractResolver for private setter deserialization - Add ObjectToNativeDictionaryConverter to convert JObject/JArray to Dictionary/List
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Get-IntersightAaaAuditRecord | select ObjectMoid,MoDisplayNamesdisplays{Name}(JObject key) instead of actual values likeBT-ntp-policy.Root Cause
For response types extending
AbstractOpenAPISchema(oneOf/anyOf wrappers likeAaaAuditRecordResponse),ApiClient.ExecClientAsynccallsFromJson()which re-deserializes usingAbstractOpenAPISchema.SerializerSettings. These settings lacked the custom converter, soSystem.Object-typed properties (likeMoDisplayNames) were left as rawJObject/JArrayinstead of being converted to native .NET types.Fix
ApiClient.mustache: AddedNonPublicSetterContractResolver(enables private-setter deserialization with camelCase mapping) andObjectToNativeDictionaryConverter(converts JObject to Dictionary, JArray to List, flattens single-element arrays to scalar for cleaner display).AbstractOpenAPISchema.mustache: Updated bothSerializerSettingsandAdditionalPropertiesSerializerSettingsto use the same resolver and converter, ensuring theFromJsondeserialization path produces native .NET types.Result
Before:
MoDisplayNames : {Name}After:
MoDisplayNames : {[Name, BT-ntp-policy]}