Default chunk task run to create a new branch#433
Open
hidetaka-cci wants to merge 1 commit into
Open
Conversation
Align chunk-cli with the Web UI by sending create-new-branch: true unless the user passes --new-branch=false to commit on the checkout branch. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--new-branchtotruesochunk task runsendscreate-new-branch: truewhen the flag is omitted, matching the Web UI.--new-branch=falseexplicitly.docs/CLI.mdand tests for the new default.Closes #432
Motivation
chunk task runwithout--new-branchcould commit agent changes directly todefault_branch(oftenmain) with no confirmation. The Web UI always setscreate-new-branch: true; chunk-cli defaulted tofalse, which is unsafe for users followingtask config→task run.Behavior change
chunk task run ...(no branch flag)create-new-branch: falsecreate-new-branch: truechunk task run ... --new-branchcreate-new-branch: truecreate-new-branch: true(unchanged)chunk task run ... --new-branch=falsecreate-new-branch: falseBreaking change: Scripts that depended on the old silent default must add
--new-branch=false.Example
Changes
internal/cmd/task.go--new-branchdefaultfalse→true; updated flag helpdocs/CLI.mdacceptance/task_test.goTestTaskRunHappyPathexpectstrue;TestTaskRunNewBranchFalsefor--new-branch=falseinternal/task/task_test.goNewBranch: true; addTestTriggerRunNoNewBranchOut of scope
--yes/--forcefor direct commitscreate-new-branch--branchordefault_branchresolutionTest plan
go test -race ./...TestTaskRunHappyPath— default payload sendscreate-new-branch: trueTestTaskRunNewBranchFalse—--new-branch=falsesendscreate-new-branch: falseTestTriggerRunNoNewBranch— unit coverage for explicitNewBranch: false