Skip to content

Fix Tasks and Workflows card alignment - #420

Open
zimm3rmann wants to merge 1 commit into
ChurchApps:mainfrom
zimm3rmann:zimm3rmann/fix-tasks-workflows-alignment
Open

Fix Tasks and Workflows card alignment#420
zimm3rmann wants to merge 1 commit into
ChurchApps:mainfrom
zimm3rmann:zimm3rmann/fix-tasks-workflows-alignment

Conversation

@zimm3rmann

Copy link
Copy Markdown

What changed

  • Apply the Tasks card's top margin only while the New Task editor is open.
  • Align the Tasks and Workflows cards on the My Work desktop layout.
  • Preserve spacing between the New Task editor and the Tasks card.

Why

The Tasks card had an unconditional marginTop: 4, while the adjacent Workflows card had no top margin. This shifted the Tasks card 32px lower.

The margin is only needed when the New Task editor is rendered above the card.

Testing

  • yarn build
  • yarn exec eslint src/serving/tasks/components/TaskList.tsx
  • Verified both cards have the same top position at 1600×900
  • Verified the cards stack without horizontal overflow at 899×900
  • Verified opening Add Task retains the intended 32px editor-to-card gap
  • Verified there are no browser console warnings or errors

@zimm3rmann

Copy link
Copy Markdown
Author

Before: image

After:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant