Docs truth: STATUS/TESTING_GUIDE accuracy + broken links

[Chris0Jeky]

Summary

Docs-only honesty fixes from the 2026-05-31 repo audit (#1138 first slice). No invented test totals — counts recertification is deferred to a green CI run (still tracked in #1138).

• STATUS.md: the read-first doc hardcoded 2026-04-25 test counts (backend 5,060 / frontend 2,805) that contradicted TESTING_GUIDE.md (6,614 / 3,267). Added an authoritative-source note pointing to TESTING_GUIDE as the single source of truth and bumped Last Updated. (The full STATUS.md split into a lean current-reality head + archive is the larger task in Docs truth & rotation: fix STATUS.md drift/bloat, repair broken links, add a link checker #1138.)
• TESTING_GUIDE.md: the "Roadmap v4 Verification Spine" still described RFAI-09: Agent runtime hardening, MCP integrity, and scheduled Inbox Digest #981 / RFAI-10: PWA share-target quick capture and browser extension prototype #982-983 / RFAI-12: Learning loop UI, provenance drawer, Ollama flag, and beta gate #984 as planned although they shipped (Agent runtime hardening: quotas, egress control, tool-hash pinning #1052 / RFAI-10: PWA share-target quick capture with offline queue #1078 / RFAI-11: Ambient channel hardening — VS Code extension + voice prototype #1079 / RFAI-12: Learning loop UI, Ollama provider, ProvenanceDrawer, cohort dashboard #1080). Marked delivered — and added an honest caveat that the CI-visible RoadmapInvariantTests for INV-10/11/12 remain [Fact(Skip)] despite the infra shipping (un-skip tracked in Recertify the CI safety floor: un-skip stale RoadmapInvariant tests (TelemetryGuard / MCP hash-pin / provenance) + DataFlowRegistry #1126; INV-09 DataFlowRegistry genuinely unbuilt).
• SIGNALR_SCALEOUT_RUNBOOK.md: ADR reference fixed ADR-0023 → ADR-0025 (0023 is the SQLite→Postgres ADR; the Redis backplane decision is 0025).
• GEMINI_CLI_GUIDE.md: ../../../ → ../../ for .gemini/settings.json, AGENTS.md, GEMINI.md, .gemini/policies/ (the guide is two levels below root; the old links overshot it).

Verification

• node scripts/check-docs-governance.mjs → passed.
• node scripts/check-golden-principles.mjs → passed.
• All four corrected link targets verified to exist on disk.

Not merging — leaving for review per the repo merge policy.

Refs #1138, #1126.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[Chris0Jeky]

Self-review

Docs-only; reviewed for accuracy and link correctness.

• No test totals invented — STATUS.md points to TESTING_GUIDE rather than asserting fresh numbers; recertification deferred to a green CI run (Docs truth & rotation: fix STATUS.md drift/bloat, repair broken links, add a link checker #1138).
• TESTING_GUIDE delivery markers cross-checked against closed issues/PRs (Agent runtime hardening: quotas, egress control, tool-hash pinning #1052/RFAI-10: PWA share-target quick capture with offline queue #1078/RFAI-11: Ambient channel hardening — VS Code extension + voice prototype #1079/RFAI-12: Learning loop UI, Ollama provider, ProvenanceDrawer, cohort dashboard #1080) and the INV-10/11/12 skip caveat verified against RoadmapInvariantTests.cs (Recertify the CI safety floor: un-skip stale RoadmapInvariant tests (TelemetryGuard / MCP hash-pin / provenance) + DataFlowRegistry #1126).
• All four corrected link targets verified present on disk.
• Docs-governance + golden-principles checks pass.

No findings. Not merging — leaving for review.

[gemini-code-assist]

Code Review

This pull request updates several documentation files: it updates the status and test total references in docs/STATUS.md, documents delivered roadmap items in docs/TESTING_GUIDE.md, corrects ADR references in docs/platform/SIGNALR_SCALEOUT_RUNBOOK.md, and fixes relative paths in docs/tooling/GEMINI_CLI_GUIDE.md. The feedback points out that the documentation in docs/TESTING_GUIDE.md incorrectly references [Fact(Skip)], which is syntactically invalid in xUnit (C#) and should be corrected to [Fact(Skip = "reason")].

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Chris0Jeky]

Review fix evidence

Gemini [MEDIUM] TESTING_GUIDE.md:43 — [Fact(Skip)] is invalid C#: correct. Changed to [Fact(Skip = "...")]. Docs-governance passes. Copilot's review errored and posted no findings.

[Chris0Jeky]

Pass-2 adversarial review (docs-only, lighter pass)

One verifier checked every load-bearing factual claim against the repo, then adversarially verified the findings. Verdict: safe to merge after one in-scope fix (pushed in this PR).

Prior bot-fix — verified present at HEAD ✅
Gemini [MEDIUM]: [Fact(Skip)] is invalid xUnit C#. HEAD (TESTING_GUIDE.md:43) reads [Fact(Skip = "...")], matching the real annotations in RoadmapInvariantTests.cs (lines 411/428/445/462).

Facts verified TRUE:

• INV mapping is exact (not swapped): INV-09→DataFlowRegistry (genuinely unbuilt — no such file), INV-10→MCP hash-pin (McpToolDefinitionHashService.cs exists), INV-11→TelemetryGuard (TelemetryGuard.cs exists), INV-12→provenance source spans (SourceSpan.cs/ProposalProvenance.cs exist). "Infra shipped but tests still skipped" is accurate (tracked Recertify the CI safety floor: un-skip stale RoadmapInvariant tests (TelemetryGuard / MCP hash-pin / provenance) + DataFlowRegistry #1126).
• ADR-0023→ADR-0025 is correct: ADR-0025 is the SignalR Redis-backplane ADR; ADR-0023 is now the SQLite→PostgreSQL ADR. Both target files exist.
• GEMINI_CLI_GUIDE.md link fixes all resolve from docs/tooling/ via ../../ (.gemini/settings.json, AGENTS.md, GEMINI.md, .gemini/policies/); no stray ../../../ remains.
• Delivery PRs all MERGED and mapped correctly (Agent runtime hardening: quotas, egress control, tool-hash pinning #1052→RFAI-09: Agent runtime hardening, MCP integrity, and scheduled Inbox Digest #981, RFAI-10: PWA share-target quick capture with offline queue #1078→RFAI-10/RFAI-10: PWA share-target quick capture and browser extension prototype #982, RFAI-11: Ambient channel hardening — VS Code extension + voice prototype #1079→RFAI-11/RFAI-11: Ambient channel hardening decision and prototype #983, RFAI-12: Learning loop UI, Ollama provider, ProvenanceDrawer, cohort dashboard #1080→RFAI-12/RFAI-12: Learning loop UI, provenance drawer, Ollama flag, and beta gate #984).
• STATUS.md note invents no totals — it defers to TESTING_GUIDE and correctly flags the in-block 2026-04-25 snapshot as drifted.

Findings

LOW (in scope) — FIXED in this PR

• The #982–#983 bullet (TESTING_GUIDE.md:42) listed "browser extension prototype" under a "both delivered" header, but PR RFAI-10: PWA share-target quick capture with offline queue #1078 explicitly deferred it ("Browser extension prototype to follow") and only a CaptureSource.BrowserExtension = 10 enum placeholder exists — no MV3/WXT artifact. A fresh overstatement that contradicts this PR's docs-truth mission. Fixed by annotating the sub-item as deferred (commit pushed; see fix-evidence reply).

LOW (out of scope) — tracked on #1138

• Pre-existing dangling anchor: TESTING_GUIDE.md:394 and :1731 link to #current-verified-totals-2026-04-25 but the live header is (2026-05-16). Untouched by this PR's diff. Tracked on Docs truth & rotation: fix STATUS.md drift/bloat, repair broken links, add a link checker #1138 (with a recommendation to use a date-free anchor + land the proposed link checker).

All required checks green; mergeable CLEAN.

[Chris0Jeky]

Fix evidence (in-scope finding)

LOW [in-scope] — #982–#983 bullet overstated a deferred 'browser extension prototype' as delivered → fixed in commit d24b40c2. The sub-item is now annotated as deferred: "PWA share target (RFAI-10, #1078; browser-extension prototype deferred — only a CaptureSource.BrowserExtension = 10 enum placeholder exists, no MV3/WXT artifact shipped)". This preserves the honest 'issue closed' framing while removing the implication that a browser extension shipped — keeping this docs-truth PR free of a fresh overstatement.

The out-of-scope dangling-anchor finding (TESTING_GUIDE.md:394/:1731) is tracked on #1138. Re-running checks before merge.