Skip to content

chore: increase listen backlog#7036

Merged
LesnyRumcajs merged 1 commit into
mainfrom
increase-min-lisen-backlog
May 12, 2026
Merged

chore: increase listen backlog#7036
LesnyRumcajs merged 1 commit into
mainfrom
increase-min-lisen-backlog

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented May 12, 2026

Summary of changes

Changes introduced in this pull request:

  • max out the connection backlog - 4096 is what Lotus defaults to as well (and most processes on my machine)

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

Release Notes

  • Chores
    • Increased network connection backlog value to align with Linux defaults and improve server resilience under high connection load.

Review Change Stack

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner May 12, 2026 08:41
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a team May 12, 2026 08:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6c5c22e0-1e6d-4340-820f-9e672e9761d6

📥 Commits

Reviewing files that changed from the base of the PR and between 17e1991 and dad11f5.

📒 Files selected for processing (1)
  • src/utils/net.rs

Walkthrough

This PR increases the minimum listen backlog constant from 1024 to 4096 in the network utilities module, with documentation updated to explain that 4096 aligns with the Linux default somaxconn value on newer kernels and matches the configuration used by Lotus and other servers.

Changes

Listen Backlog Configuration

Layer / File(s) Summary
Listen backlog constant increase
src/utils/net.rs
MIN_LISTEN_BACKLOG is raised from 1024 to 4096 with updated documentation clarifying alignment with Linux default somaxconn and usage patterns in other servers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • ChainSafe/forest#7034: Modifies the same MIN_LISTEN_BACKLOG constant and related TCP listen backlog logic in src/utils/net.rs.

Suggested reviewers

  • hanabi1224
  • sudo-shashank
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: increase listen backlog' accurately and concisely describes the main change: increasing the MIN_LISTEN_BACKLOG constant from 1024 to 4096.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch increase-min-lisen-backlog
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch increase-min-lisen-backlog

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs enabled auto-merge May 12, 2026 08:42
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.13%. Comparing base (17e1991) to head (dad11f5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/utils/net.rs 43.90% <ø> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e1991...dad11f5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit 129da99 May 12, 2026
34 checks passed
@LesnyRumcajs LesnyRumcajs deleted the increase-min-lisen-backlog branch May 12, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants