fix: try re-enable buildjet for RPC checks#6201
Conversation
WalkthroughThe rpc-parity GitHub Actions workflow runner environment was updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/rpc-parity.yml (2)
9-9: Add inline documentation explaining the BuildJet migration.The PR description mentions this resolves Lotus OOM issues, but this context is not captured in code. Add a comment above the
runs-onfield to document the rationale, making future maintainers aware of the decision and its trade-offs.Apply this diff to add context:
rpc-parity: name: RPC parity tests + # Using BuildJet (third-party runner) to mitigate Lotus OOM issues + # observed with ubuntu-24.04. If OOM issues persist, consider reverting + # to ubuntu-24.04 or investigating heap limits. runs-on: buildjet-8vcpu-ubuntu-2204
9-9: Add actionlint configuration to suppress custom runner warning.BuildJet is confirmed as a legitimate third-party GitHub Actions runner service (Y Combinator startup). The workflow is already properly configured to mitigate OOM issues by relocating Docker volumes to
/mnt(60GB+ available space).However, actionlint will flag
buildjet-8vcpu-ubuntu-2204as an unknown runner label. Add.github/actionlint.ymlto suppress this:self-hosted-runner: labels: - buildjet-8vcpu-ubuntu-2204Optionally, add an inline comment in the workflow explaining the OOM mitigation rationale for future reference.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/rpc-parity.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/rpc-parity.yml
9-9: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-11-arm", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-26-xlarge", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: tests-release
- GitHub Check: tests
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #6029
Other information and links
Change checklist
Summary by CodeRabbit