Skip to content

feat: save chain metadata to files instead of database#2635

Merged
hanabi1224 merged 17 commits intomainfrom
hm/save-chain-meta-to-file
Mar 10, 2023
Merged

feat: save chain metadata to files instead of database#2635
hanabi1224 merged 17 commits intomainfrom
hm/save-chain-meta-to-file

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Mar 7, 2023

Summary of changes

Changes introduced in this pull request:

As part of #2292

  • Save genesis block header and heaviest tipset keys to files instead of database

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review March 7, 2023 15:29
Comment thread blockchain/chain/src/store/chain_store.rs Outdated
Comment thread blockchain/chain/src/store/chain_store.rs Outdated
Comment thread utils/forest_utils/src/db/file_backed_obj.rs Outdated
@hanabi1224 hanabi1224 mentioned this pull request Mar 8, 2023
8 tasks
Comment thread blockchain/chain/src/store/chain_store.rs Outdated
@hanabi1224 hanabi1224 force-pushed the hm/save-chain-meta-to-file branch from b0a671c to 4046e82 Compare March 8, 2023 17:00
Comment thread blockchain/chain/src/store/chain_store.rs Outdated
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanabi1224 Could you please write a short note on why we want to save metadata for files instead of the database in this PR? It's nice to have some trace, for the well-being of future us, trying to understand the reason behind changes.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Hubert <hubert@chainsafe.io>
@hanabi1224
Copy link
Copy Markdown
Contributor Author

hanabi1224 commented Mar 10, 2023

@LesnyRumcajs Sure, the idea is to only save block data which are content-addressed to the DB, so that we could

@hanabi1224 hanabi1224 enabled auto-merge (squash) March 10, 2023 02:59
@hanabi1224 hanabi1224 merged commit bca2220 into main Mar 10, 2023
@hanabi1224 hanabi1224 deleted the hm/save-chain-meta-to-file branch March 10, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants