feat: save chain metadata to files instead of database#2635
Merged
hanabi1224 merged 17 commits intomainfrom Mar 10, 2023
Merged
feat: save chain metadata to files instead of database#2635hanabi1224 merged 17 commits intomainfrom
hanabi1224 merged 17 commits intomainfrom
Conversation
lemmih
suggested changes
Mar 8, 2023
8 tasks
lemmih
reviewed
Mar 8, 2023
b0a671c to
4046e82
Compare
lemmih
reviewed
Mar 8, 2023
lemmih
approved these changes
Mar 8, 2023
LesnyRumcajs
approved these changes
Mar 9, 2023
Member
LesnyRumcajs
left a comment
There was a problem hiding this comment.
@hanabi1224 Could you please write a short note on why we want to save metadata for files instead of the database in this PR? It's nice to have some trace, for the well-being of future us, trying to understand the reason behind changes.
Co-authored-by: Hubert <hubert@chainsafe.io>
Contributor
Author
|
@LesnyRumcajs Sure, the idea is to only save block data which are content-addressed to the DB, so that we could
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
As part of #2292
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist