Skip to content

Conversation

@jjspace
Copy link
Contributor

@jjspace jjspace commented Nov 3, 2025

Description

In this release we're removing the banner pointing to legacy sandcastle as the new version of sandcastle should be stable and is the one we want people to use.

The legacy version still exists in the repo and the downloaded zip file should someone really needed. As per discussion in #12904 this will likely change next release.

Issue number and link

No issue

Testing plan

  • Open sandcastle locally or in CI
  • Verify the banner is gone on the new sandcastle

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from jjhembd November 3, 2025 16:10
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjspace, this looks good to me. I verified it both locally and on CI.

@jjhembd jjhembd added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 96c4ca3 Nov 3, 2025
13 of 14 checks passed
@jjhembd jjhembd deleted the remove-banner branch November 3, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants