Skip to content

general unsafety issue - many overrides of virtual methods marked const by methods not marked const #67

@weatherhead99

Description

@weatherhead99

there are many methods throughout the code (e.g. in the Archon::Nirc2 namespace) where a base class method that is marked const is overridden (well, technically in c++ standard parlance "hidden" not "overridden" because that would imply the same method signature) by a method of the same name which is not marked const.

At least in a few cases I've looked at the overriding methods could be const so this is just a (very slight) memory safety issue. These will show up at least as warnings on modern compilers I believe.

Cheers,
DW

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions