fix(rule_translator): correct guard logic for None / all-None-list values#183
Open
SoundMatt wants to merge 1 commit into
Open
fix(rule_translator): correct guard logic for None / all-None-list values#183SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
…alues
The guard before `set_attr` read:
if value != None and (isinstance(value, list) and not all(...)):
The second operand of `and` requires `value` to be a list, so any
non-None scalar value (str, int, AST object) was silently dropped,
because a scalar is not a list — and that sub-expression was False.
The intent is: skip if value is None, *or* if value is a list whose
every element is None. The correct condition is:
if value is not None and (not isinstance(value, list) or not all(...)):
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
transform, after callingtransform_value_common, the result is only stored if it is not empty:The bug: the second operand of
andrequiresvalueto be a list. Ifvalueis any non-None scalar (astr,int, or an AST node),isinstance(value, list)isFalse, so the whole right-hand side isFalse, and the attribute is silently discarded. This causes every non-list field in every translated object to be dropped.The intended guard is: skip if
value is None, or ifvalueis a list where every element isNone. The correct expression: