fix(franca_to_ifex): remove duplicate franca.Int16 entry in type_translation#177
Open
SoundMatt wants to merge 1 commit into
Open
fix(franca_to_ifex): remove duplicate franca.Int16 entry in type_translation#177SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
…ation `type_translation` contained `franca.Int16 : "int16"` twice. Python silently uses the last entry, so the duplicate is harmless here, but it is misleading and could mask a real mistake (e.g. if the second occurrence had been intended to map to a different type). Remove the duplicate line. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type_translationcontained the entryfranca.Int16 : "int16"twice. Python silently uses the last definition for any duplicate dict key. Here both values are the same so the mapping is still correct, but the duplicate is misleading and would mask a copy-paste error if the second entry were ever changed to a different target type. Remove the duplicate line.