fix(generator, generator_dbus): remove undefined filename variable from error message#174
Open
SoundMatt wants to merge 1 commit into
Open
fix(generator, generator_dbus): remove undefined filename variable from error message#174SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
…om error messages Both entrypoints referenced `filename` in an f-string error message, but `filename` is never defined in scope at that point — `args.input` is the correct name, and args is only set inside the try block. Remove the interpolation to avoid masking the original error with a `NameError`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
generator.pyandgenerator_dbus.pyreferencedfilenamein the except-clause error message:filenameis never defined in either function's scope — the parsed argument isargs.input, andargsis only assigned inside thetryblock. If the exception were actually raised, it would be immediately followed by aNameError, hiding the original error. Simplify the message to remove the undefined variable.