Fix DLT file append failure and resolve path encoding for non-Latin1 characters characters#790
Open
wobuxie1997 wants to merge 1 commit into
Open
Fix DLT file append failure and resolve path encoding for non-Latin1 characters characters#790wobuxie1997 wants to merge 1 commit into
wobuxie1997 wants to merge 1 commit into
Conversation
wobuxie1997
commented
Mar 24, 2026
Contributor
- Fix file opening issues in environments with non-Latin1 characters (e.g., Chinese) by using toLocal8Bit() instead of toLatin1() for dlt_file_open calls.
- Fix on_tabExplore_filesAppendRequest to correctly handle appending .dlt files by invoking appendDltFile.
- Add support for appending .dlf filter files and improve handling for PCAP/MF4 files in the file explorer's append request.
- Refactor file open and append logic in MainWindow for better consistency and broader file type support.
Contributor
Author
|
@shubhamshahaBMW I have fixed the vulnerability related to appending files and verified the fix in a Linux environment. During the process, I discovered that calling dlt_open_file fails in non-Latin (e.g., Chinese) environments. Regarding the "show in explorer" failure mentioned in #779, I was unable to reproduce it locally; currently, "show in explorer" only works when a single file or folder is selected. |
f6aad23 to
ed9f500
Compare
ed9f500 to
0959f4a
Compare
…characters - Fix file opening issues in environments with non-Latin1 characters (e.g., Chinese) by using toLocal8Bit() instead of toLatin1() for dlt_file_open calls. - Fix on_tabExplore_filesAppendRequest to correctly handle appending .dlt files by invoking appendDltFile. - Add support for appending .dlf filter files and improve handling for PCAP/MF4 files in the file explorer's append request. - Refactor file open and append logic in MainWindow for better consistency and broader file type support.
0959f4a to
d0bc4b0
Compare
Collaborator
|
Hi @wobuxie1997 , Show in explorer is not working in windows. Apart from this, the changes looks file. |
shubhamshahaBMW
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.