fix: getPathToUseCases returns mutable global instead of frozen static local - #115
Open
SoundMatt wants to merge 1 commit into
Open
fix: getPathToUseCases returns mutable global instead of frozen static local#115SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
…c local getPathToUseCases initialised a static const local on first call, freezing the value of USE_CASES_PATH at that point. Any subsequent call to setPathToUseCases updated the global but had no effect because the already-initialised static was returned instead. Remove the static local and return USE_CASES_PATH directly so that setPathToUseCases takes effect on all subsequent calls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getPathToUseCases()initialises astatic const std::string use_cases_path = USE_CASES_PATHon its first call. Any later call tosetPathToUseCases()updatesUSE_CASES_PATHbut the already-frozen static local is returned on every subsequent call, making the setter silently a no-op after first use.Root cause
C++
staticlocal variables are initialised exactly once. Assigning to the module-levelUSE_CASES_PATHafter the first call togetPathToUseCaseshas no effect becauseuse_cases_pathwas already bound to the old value.Fix
Remove the
static constlocal and returnUSE_CASES_PATHdirectly. This is a one-line change that makes the getter reflect the current value of the global and allowssetPathToUseCasesto take effect at any time.