fix: add OnDestroy to FeedComponent to prevent memory leaks#198
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
fix: add OnDestroy to FeedComponent to prevent memory leaks#198devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
Implement OnDestroy lifecycle hook to unsubscribe from typeSub and pageSub subscriptions when the component is destroyed. Previously, navigating away from feed pages would leave stale subscriptions running, causing memory leaks and potential ghost updates. Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
OnDestroylifecycle hook toFeedComponentto unsubscribe fromtypeSubandpageSubwhen the component is destroyed. Previously, navigating away from feed pages left these subscriptions alive, causing memory leaks and potential ghost updates from stale callbacks.Review & Testing Checklist for Human
pageSub's callback (ngOnInitline 47–55),fetchFeed(...).subscribe(...)creates a new subscription on every route param change that is never stored or unsubscribed. This PR does not address that inner subscription — confirm whether it also needs cleanup (it likely does if users navigate between pages rapidly).ng testto confirm existing tests still pass — tests were not executed during this session.Notes