Merged
Conversation
Cyl18
pushed a commit
that referenced
this pull request
Aug 8, 2023
Delete projects/1.12.2/assets/conquest-reforged/minecraft/lang directory 算是个workaround吧，后续可能还要接着研究
mamaruo
added a commit
that referenced
this pull request
Aug 8, 2023
* initial commit * Update CONTRIBUTING.md * Update README.md * 调整标题匹配正则，阻止“中文+英文+中文”的格式 * 更新 CONTRIBUTING * Update README * Update README * fix README * Update README * Update README-en.md * Update README-en.md * Update CONTRIBUTING.md * 小修 * Update boring-cyborg.yml * 小修 * 添加 翻译内容审查 部分，对其他部分进行微调 部分可能不合适，之后会进行更改 * 修改 翻译内容审查 部分，新增”7+7“ * 更改 `CurseForge 项目名称` 部分 新增：Modrinth独占模组提交的情况；未发布在CurseForge与Modrinth的模组提交的情况 * 更新 翻译用语共识 新增关于”木制品名称“的翻译用语共识 * 更改链接 现在不会错误的显示了 * 小修小补 * Update CONTRIBUTING.md * 标题验证正则更新 * help wanted 自动化丨小删改 * 删除 WIP丨中文化丨棘手标签匹配 * 优化贡献方针用语 some changes * 搁置规则 * 根据仙人掌的意见修改 * 更新英文自述文件 * 1.20 新建基本文件 * Update CONTRIBUTING.md * 按审阅修改CONTRIBUTING，README；其他小修改 * 明确“动态”的含义 * Update CONTRIBUTING.md Co-authored-by: Cactus_student <97865546+Cactusstudent@users.noreply.github.com> * 优化关于搁置的问题 * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Cactus_student <97865546+Cactusstudent@users.noreply.github.com> * some fix * Update CONTRIBUTING.md * 修复 .md * 删除贡献方针中冗余的定义 * 细化搁置方针；stale.yml更新 * Update PULL_REQUEST_TEMPLATE.md * 检查单->CLA * Update CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: Cactus_student <97865546+Cactusstudent@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Cactus_student <97865546+Cactusstudent@users.noreply.github.com> * Update README.md * Update CONTRIBUTING.md Co-authored-by: dovisutu <40313014+dovisutu@users.noreply.github.com> * 贡献方针小修；stale 优化 * config废弃；措辞优化 * 贡献方针新增小版本优先级说明 * 优化 * 删除标题验证器 * Update packer.json * 临时修复packer报错问题 (#3635) Delete projects/1.12.2/assets/conquest-reforged/minecraft/lang directory 算是个workaround吧，后续可能还要接着研究 * Revert "Update packer.json" This reverts commit c049a7c. --------- Co-authored-by: Cactusstudent <97865546+Cactusstudent@users.noreply.github.com> Co-authored-by: dovisutu <40313014+dovisutu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
出于未知原因，Packer的部分执行逻辑在未知情况下会执行两次。由于处理非文本文件的代码不够健壮，在重复执行时将会崩溃。
该问题是与“无语言标记的文件会被丢弃”同时引入的，因此被掩盖了。直到后者被修复，该问题的严重性才暴露出来。
这里引入的是一个临时修复：删除与minecraft的命名空间碰撞似乎可以避免上述重复执行——至少从本pr的执行情况，与3288中类似的测试看，是如此。
如果不行，另一个临时修复是将崩溃相关的代码略做调整，使其仍能正常工作——但前提是我有时间改，或者有人帮忙改。
问题源可能很难定位；可能是代码逻辑的纰漏，但如果不是，那就麻烦了。