Conversation
WalkthroughUpdates project compatibility to NetBox 4.4.x: README matrix row added, plugin min/max versions bumped to 4.4.x, and import paths in NetboxPluginReloaderConfig.ready() adjusted. Package version updated to 4.4.0. No functional logic changes beyond import path updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
netbox_plugin_reloader/__init__.py (1)
34-35: Use Django’s public import path for apps.
Prefer the stable APIfrom django.apps import apps; importing fromdjango.apps.registryrelies on internals and may break across Django releases.Apply this diff:
- from django.apps.registry import apps + from django.apps import appsPlease confirm CI against NetBox 4.4.x passes with this public import.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
README.md(1 hunks)netbox_plugin_reloader/__init__.py(2 hunks)netbox_plugin_reloader/version.py(1 hunks)
🔇 Additional comments (4)
README.md (1)
19-20: LGTM: compatibility row for 4.4.x is clear and consistent with the new package version.netbox_plugin_reloader/version.py (1)
3-3: Version bump to 4.4.0 looks good.
Consider tagging the release and updating the changelog to match.netbox_plugin_reloader/__init__.py (2)
23-25: LGTM: plugin compatibility window updated to 4.4.x.
Matches README and version.py.
34-34: Confirm ObjectType import path for 4.4.
from core.models.object_types import ObjectTypelooks right for 4.4, but double-check against the exact NetBox 4.4.x you target to avoid import errors.
Summary by CodeRabbit
New Features
Documentation
Chores