Skip to content

NetBox v4.4 upgrade#4

Merged
Kani999 merged 1 commit intomasterfrom
netbox_4_4
Sep 3, 2025
Merged

NetBox v4.4 upgrade#4
Kani999 merged 1 commit intomasterfrom
netbox_4_4

Conversation

@Kani999
Copy link
Copy Markdown
Collaborator

@Kani999 Kani999 commented Sep 3, 2025

Summary by CodeRabbit

  • New Features

    • Added compatibility with NetBox 4.4.x.
  • Documentation

    • Updated the compatibility matrix to include NetBox 4.4.x alongside existing 4.2.x and 4.3.x entries.
  • Chores

    • Bumped plugin version to 4.4.0.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 3, 2025

Walkthrough

Updates project compatibility to NetBox 4.4.x: README matrix row added, plugin min/max versions bumped to 4.4.x, and import paths in NetboxPluginReloaderConfig.ready() adjusted. Package version updated to 4.4.0. No functional logic changes beyond import path updates.

Changes

Cohort / File(s) Summary
Documentation: Compatibility Matrix
README.md
Added NetBox 4.4.x ↔ plugin 4.4.x row in the matrix.
Plugin Config: Compatibility & Imports
netbox_plugin_reloader/__init__.py
Bumped min_version to "4.4.0" and max_version to "4.4.99". Updated imports: core.models.ObjectTypecore.models.object_types.ObjectType, django.apps.appsdjango.apps.registry.apps.
Package Version
netbox_plugin_reloader/version.py
Updated __version__ from "4.3.1" to "4.4.0".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A rabbit taps the version drum, 4.4—hop, hooray!
Matrix rows align in time, compatibility on display.
Imports nudge their paths anew, tidy as fresh hay.
With whiskers twitch and gentle thump,
This plugin’s set for the 4.4 romp! 🥕✨

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch netbox_4_4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
netbox_plugin_reloader/__init__.py (1)

34-35: Use Django’s public import path for apps.
Prefer the stable API from django.apps import apps; importing from django.apps.registry relies on internals and may break across Django releases.

Apply this diff:

-        from django.apps.registry import apps
+        from django.apps import apps

Please confirm CI against NetBox 4.4.x passes with this public import.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4e80f64 and e2d53dd.

📒 Files selected for processing (3)
  • README.md (1 hunks)
  • netbox_plugin_reloader/__init__.py (2 hunks)
  • netbox_plugin_reloader/version.py (1 hunks)
🔇 Additional comments (4)
README.md (1)

19-20: LGTM: compatibility row for 4.4.x is clear and consistent with the new package version.

netbox_plugin_reloader/version.py (1)

3-3: Version bump to 4.4.0 looks good.
Consider tagging the release and updating the changelog to match.

netbox_plugin_reloader/__init__.py (2)

23-25: LGTM: plugin compatibility window updated to 4.4.x.
Matches README and version.py.


34-34: Confirm ObjectType import path for 4.4.
from core.models.object_types import ObjectType looks right for 4.4, but double-check against the exact NetBox 4.4.x you target to avoid import errors.

@Kani999 Kani999 merged commit 4072827 into master Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants