refactore: Implement marker bit validation with debug output in user data parsing.#2113
refactore: Implement marker bit validation with debug output in user data parsing.#2113AhmedAlian7 wants to merge 2 commits intoCCExtractor:masterfrom
Conversation
This adds a validation check for the SCTE 20 marker bit in es_userdata.c. If the bit is 0, a debug warning is logged. This prevents potential parsing issues with corrupt streams.
51de8f2 to
083a606
Compare
|
@cfsmp3, plz review this one. |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 6f7ce27...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 6f7ce27...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
|
Closing as duplicate of #2130, which addresses the same SCTE-20 marker bit TODO. #2130 is the better fix because it:
Additionally, this PR has a duplicate CHANGES.TXT entry — it adds "Fix: segmentation fault when using --multiprogram" which already exists in the file. Thank you for the contribution — the fix idea was correct, just #2130 was more complete. |
[FEATURE]
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
SCTE 20 Marker Bit Syntax Check
closes #2112
I have implemented a syntax check for the SCTE 20 marker bit in
es_userdata.c. This ensures that the parser verifies the marker bit is '1' as per the standard, and logs a debug warning if it is not.Changes
src/lib_ccx/es_userdata.cI replaced the TODO comment with a check that reads the bit and logs a warning if it is 0.
Verification Results
Automated Verification
es_userdata.cwithgccto ensure no syntax errors were introduced.dbg_printis used correctly withCCX_DMT_VERBOSElevel, which is consistent with other debug prints in the file.