add manual input to graphical select widget#285
Merged
Conversation
2767mr
approved these changes
Aug 8, 2023
Member
2767mr
left a comment
There was a problem hiding this comment.
Looks good, although I would have expected it to be above the filter or even in the same textbox
lexisother
suggested changes
Aug 22, 2023
Member
lexisother
left a comment
There was a problem hiding this comment.
I'd prefer if this PR also added support for ScalableProp and ItemDestruct before it is merged.
moved manual input outside of image select widget
Member
Author
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #278
Added input so types from mods or missing ones can still be used.
Not added for
ScalablePropandItemDestructbecause they have additional logic for setting a value