Skip to content

Update progress to support semantic variables#6919

Draft
GZolla wants to merge 1 commit into
mainfrom
gzolla/dark-progress
Draft

Update progress to support semantic variables#6919
GZolla wants to merge 1 commit into
mainfrom
gzolla/dark-progress

Conversation

@GZolla
Copy link
Copy Markdown
Contributor

@GZolla GZolla commented May 6, 2026

GAUD-9479

Note the slight change to the inset shadow

@GZolla GZolla requested a review from a team as a code owner May 6, 2026 01:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-6919/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Copy link
Copy Markdown
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good me 👍

@dbatiste
Copy link
Copy Markdown
Contributor

I think this is blocked on review of how the semantics of progress, meters, loading, and status are represented in the palette.

@dlockhart
Copy link
Copy Markdown
Member

I think this is blocked on review of how the semantics of progress, meters, loading, and status are represented in the palette.

Ah ok, I just reviewed it because it was showing up in our daily alerts of outstanding reviews. Maybe we can move it back to Draft until that's resolved?

@dbatiste
Copy link
Copy Markdown
Contributor

I think this is blocked on review of how the semantics of progress, meters, loading, and status are represented in the palette.

Ah ok, I just reviewed it because it was showing up in our daily alerts of outstanding reviews. Maybe we can move it back to Draft until that's resolved?

That's a good call!

@GZolla GZolla marked this pull request as draft May 28, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants