Merged
Conversation
Owner
|
Thanks, please rebase on v0.6.1 branch and add a note to the changelog there. The build should be fixed now. Edit: This will probably be the last change for the v0.6.1 release, which I'm aiming for later this week. |
Collaborator
Author
|
Funny enough, the function argument wasn't wrong in the 0.6.1 branch, but it was just left unnamed and positional. So, to be explicit, I included the correct argument name in the updated PR. |
Breakthrough
approved these changes
Nov 16, 2022
Owner
|
Thank you for tackling this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #299 and corrects the named function argument. @Breakthrough let me know if I should rebase on a different branch.