deploy: show changed files in PR #1828

heerener · 2023-02-10T09:27:45Z

No description provided.

bbpbuildbot · 2023-02-10T09:30:25Z

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

Placeholders for new functions, and first type hints

Check for all changed packages, docs and deploy changes Ignore PR title for now.

matz-e · 2023-02-10T14:38:39Z

.github/workflows/validate-commit-message.py

+    prefixes = collect_prefixes()
+
+    unmentioned_packages = get_unmentioned_packages(prefixes, changed_files)
+    if unmentioned_packages:


Devil's advocate: if we mass-update the copyright, this is going to blow up :D

Very good point - maybe we should temporarily turn this off for that kind of changes 🥷

Or define a custom threshold like 3 or 5 packages changed total?

github-actions · 2023-02-10T15:18:46Z

There are one or more issues with the commit message of commit 897d25c.
Commit message:

More newlines... MORE!

Issues:

      * 897d25c1054605680eb4bc0fdcabf6aa20347344

More newlines... MORE!

        The following packages were changed but not mentioned:
        arrow
        You can simply use the above list followed by a colon, then explain what you changed.
        Alternatively, you can use a line per package to describe the change per package.

      * 897d25c1054605680eb4bc0fdcabf6aa20347344

More newlines... MORE!

        Deploy files were changed but not mentioned in the commit message.
        Please use the deploy: prefix to explain this change.

github-actions · 2023-02-14T10:03:22Z

There are one or more issues with the title of this PR.
Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant.
Issues:

The following packages were changed but not mentioned:
libsonata, arrow, neuron:
You can simply use the above list, then explain what you changed.
Alternatively, you can use one line per package to describe the change per package.
Please mention at least one package.
Deploy files were changed but not mentioned in the commit message.
Please use the deploy: prefix to explain this change.

This reverts commit 72dde75.

github-actions · 2023-02-14T10:24:14Z

There are one or more issues with the title of this PR.
Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant.
Issues:

The following packages were changed but not mentioned:
arrow:
You can simply use the above list, then explain what you changed.
Alternatively, you can use one line per package to describe the change per package.
Please mention at least one package.
Deploy files were changed but not mentioned in the commit message.
Please use the deploy: prefix to explain this change.

This reverts commit 0b3f8ed.

github-actions · 2023-02-14T10:31:50Z

There are one or more issues with the title of this PR.
Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant.
Issues:

The following packages were changed but not mentioned:
arrow:
You can simply use the above list, then explain what you changed.
Alternatively, you can use one line per package to describe the change per package.
Please mention at least one package.
Deploy files were changed but not mentioned in the commit message.
Please use the deploy: prefix to explain this change.

github-actions · 2023-02-14T10:32:36Z

There are one or more issues with the title of this PR.
Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant.
Issues:

The following packages were changed but not mentioned:
arrow:
You can simply use the above list, then explain what you changed.
Alternatively, you can use one line per package to describe the change per package.
Please mention at least one package.
Deploy files were changed but not mentioned.
Please use the deploy: prefix to explain this change.

github-actions · 2023-02-14T10:41:47Z

There are one or more issues with the title of this PR.
Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant.
Issues:

Deploy files were changed but not mentioned.
Please use the deploy: prefix to explain this change.

bbpbuildbot · 2023-02-14T11:18:30Z

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

arrow (yplj3bytef5ftoimggve2xofvihp56l6)

github-actions · 2023-02-14T12:08:27Z

There are one or more issues with the title of this PR.
Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant.
Issues:

Deploy files were changed but not mentioned.
Please use the deploy: prefix to explain this change.

github-actions · 2023-02-14T12:16:09Z

There are one or more issues with the title of this PR.
Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant.
Issues:

Deploy files were changed but not mentioned.
Please use the deploy: prefix to explain this change.

bbpbuildbot · 2023-02-15T11:38:02Z

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

arrow (yplj3bytef5ftoimggve2xofvihp56l6)

bbpbuildbot · 2023-02-16T11:56:48Z

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

arrow (yplj3bytef5ftoimggve2xofvihp56l6)

bbpbuildbot · 2023-02-17T08:34:31Z

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

arrow (yplj3bytef5ftoimggve2xofvihp56l6)

bbpbuildbot · 2023-02-18T08:53:21Z

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

arrow (yplj3bytef5ftoimggve2xofvihp56l6)

bbpbuildbot · 2023-02-19T09:13:24Z

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

arrow (yplj3bytef5ftoimggve2xofvihp56l6)

bbpbuildbot · 2023-02-20T09:47:38Z

The following build jobs of the deployment for this PR failed:

test / update_config

heerener added 4 commits January 30, 2023 11:01

nopackage: support for multiple packages in prefix

bc94fae

nopackage: strip all the keywords

ccc411e

nopackage: show changed files in PR

1909d61

arrow: temporarily remove patch to test

0b3f8ed

heerener added 11 commits February 10, 2023 10:32

nopackage: changed files as json

2e96c60

nopackage: formatting validate-commit-message.py

6ac2d6c

Placeholders for new functions, and first type hints

nopackage: pass changed files and fetch-depth 0

1e50585

nopackage: specify ref

2c8c3b3

nopackage: only check last commit

c629a9b

nopackage: show which commit is being checked

5d166c9

nopackage: kick job

13b1e9e

Merge branch 'multi-package-commit' into upgrade-complainah

634813b

nopackage: style and further work on validate-commit-message

f24911a

validate-commit-message: upgrade

0249880

Check for all changed packages, docs and deploy changes Ignore PR title for now.

Merge branch 'develop' into upgrade-complainah

45a33e2

BlueBrain deleted a comment from github-actions bot Feb 10, 2023

Set fail state by default to catch script failures

a9fb5a7

matz-e reviewed Feb 10, 2023

View reviewed changes

heerener added 7 commits February 10, 2023 15:38

Introduce script-failure variable

584344d

More debug logging

928d3dd

No more deepening is required

35d1d87

Fix indentation error

0ea238b

In-line replace script-failure=true with script-failure=false

c854061

Let there be newlines

97e99b8

More newlines... MORE!

897d25c

heerener added 5 commits February 14, 2023 11:15

DYI changed files

e54389f

Fun with quotes

72dde75

Revert "Fun with quotes"

cfc7514

This reverts commit 72dde75.

Set -x

1c858e7

Correct output name

2316465

heerener added 2 commits February 14, 2023 11:30

Revert "arrow: temporarily remove patch to test"

df94fb1

This reverts commit 0b3f8ed.

Less ambiguity in the comment

83b3d1b

Stop hardcoding things

c6035f3

heerener added 2 commits February 14, 2023 11:46

Checkout without fancy parameters

0f71488

okay, one fancy parameter then

707cdfb

More debug info

35d32ba

heerener changed the title ~~nopackage: show changed files in PR~~ deploy: show changed files in PR Feb 14, 2023

We don't need all the debug info any more

4b9c635

matz-e approved these changes Feb 20, 2023

View reviewed changes

heerener merged commit dad94f6 into develop Feb 20, 2023

heerener deleted the upgrade-complainah branch February 20, 2023 09:59

deploy: show changed files in PR #1828

deploy: show changed files in PR #1828

Uh oh!

Conversation

heerener commented Feb 10, 2023

Uh oh!

bbpbuildbot commented Feb 10, 2023

Uh oh!

matz-e Feb 10, 2023

Choose a reason for hiding this comment

Uh oh!

heerener Feb 10, 2023

Choose a reason for hiding this comment

Uh oh!

matz-e Feb 10, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 10, 2023

Uh oh!

github-actions bot commented Feb 14, 2023

Uh oh!

github-actions bot commented Feb 14, 2023

Uh oh!

github-actions bot commented Feb 14, 2023

Uh oh!

github-actions bot commented Feb 14, 2023

Uh oh!

github-actions bot commented Feb 14, 2023

Uh oh!

bbpbuildbot commented Feb 14, 2023

Uh oh!

github-actions bot commented Feb 14, 2023

Uh oh!

github-actions bot commented Feb 14, 2023

Uh oh!

bbpbuildbot commented Feb 15, 2023

Uh oh!

bbpbuildbot commented Feb 16, 2023

Uh oh!

bbpbuildbot commented Feb 17, 2023

Uh oh!

bbpbuildbot commented Feb 18, 2023

Uh oh!

bbpbuildbot commented Feb 19, 2023

Uh oh!

bbpbuildbot commented Feb 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants