This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix NVHPC + OpenMP ~ OpenACC compilation #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is being tested with BlueBrain/CoreNeuron#717. |
Collaborator
|
Logfiles from GitLab pipeline #29209 (:white_check_mark:) have been uploaded here! Status and direct links: |
1 task
olupton
added a commit
that referenced
this pull request
Dec 22, 2021
* Tweak NVHPC warning suppressions.
* Emit nrn_pragma_{acc,omp}(...) macros. (#780)
* Use cnrn_target_ wrappers instead of acc_ API.
* GPU code generation improvements (#782)
* Fix NVHPC + OpenMP ~ OpenACC compilation (#784)
* Add EIGEN_DEVICE_FUNC to header to fix a compilation warning.
* Fudge partialPivLu<N> for NVHPC + OpenMP without OpenACC.
* Transfer ml only if cell is not artificial. (#785)
* Update Eigen to include OpenMP fixes. (#787, #789)
Co-authored-by: Nicolas Cornu <[email protected]>
Co-authored-by: Pramod Kumbhar <[email protected]>
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
* Tweak NVHPC warning suppressions.
* Emit nrn_pragma_{acc,omp}(...) macros. (BlueBrain/nmodl#780)
* Use cnrn_target_ wrappers instead of acc_ API.
* GPU code generation improvements (BlueBrain/nmodl#782)
* Fix NVHPC + OpenMP ~ OpenACC compilation (BlueBrain/nmodl#784)
* Add EIGEN_DEVICE_FUNC to header to fix a compilation warning.
* Fudge partialPivLu<N> for NVHPC + OpenMP without OpenACC.
* Transfer ml only if cell is not artificial. (BlueBrain/nmodl#785)
* Update Eigen to include OpenMP fixes. (BlueBrain/nmodl#787, BlueBrain/nmodl#789)
Co-authored-by: Nicolas Cornu <[email protected]>
Co-authored-by: Pramod Kumbhar <[email protected]>
NMODL Repo SHA: BlueBrain/nmodl@46f8baf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#pragma acc routine seqseems to play better with templates than#pragma omp declare targetdoes. Here is a hideous workaround...