This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Bump minimum supported CMake version to 3.15 #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Logfiles from GitLab pipeline #14099 (:no_entry:) have been uploaded here! Status and direct links:
|
Contributor
Author
|
@olupton please update if necessary and merge at your convenience 🚀 |
olupton
approved these changes
Aug 19, 2021
Contributor
olupton
left a comment
There was a problem hiding this comment.
LGTM. I don't see any urgent need to update the NMODL submodule.
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
This version was already required for GPU builds. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@5da235e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following an internal discussion, we've decided to bump minimum CMake version to 3.15 for maintainability purposes.
Driven by #609.
CI_BRANCHES:NEURON_BRANCH=cmake315,