This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Remove call to acc_shutdown when cleaning up GPU data. #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This invoked undefined behaviour in case CoreNEURON was executed on GPU multiple times in the same process.
pramodk
approved these changes
May 10, 2021
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
This invoked undefined behaviour when CoreNEURON was executed on GPU multiple times in the same process. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@3a4d5b5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the call to
acc_shutdown(acc_device_nvidia)(OpenACC API) when cleaning up GPU data. This invoked undefined behaviour in case CoreNEURON was executed on GPU multiple times in the same process. See also: #515.How to test this?
The
coreneuron_modtests::datareturn_pytest, which runs three multiple CoreNEURON simulations from one Python script, is sensitive to this issue. This was not actually failing onmaster, but it probably could have been. Some other draft modifications that used theacc_map_dataandacc_unmap_datacalls exposed the issue.Test System
Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=master,