This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Psolve direct #528
Merged
Psolve direct #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Framework allows sequence of psolve without intervening finitialize. Trajectory recording appends to Vectors.
But at least not causing crash if not using net_move. This fixed tests 30, 57, 60. Tests 71, 74, 79 still failing (watch and vecplay).
Member
|
Please retest |
testcorenrn WATCH test runs successfully with mode 2.
Collaborator
|
Logfiles from GitLab pipeline #14286 (:no_entry:) have been uploaded here! Status and direct links:
|
Collaborator
|
Logfiles from GitLab pipeline #14291 (:no_entry:) have been uploaded here! Status and direct links:
|
Collaborator
|
Logfiles from GitLab pipeline #14343 (:no_entry:) have been uploaded here! Status and direct links:
|
Collaborator
In last CI, above test failed on GPU with MOD2C as well as NMODL! |
Collaborator
|
Logfiles from GitLab pipeline #14379 (:no_entry:) have been uploaded here! Status and direct links:
|
Add references to #611 in comments.
Contributor
|
The last pipeline on GitLab https://bbpgitlab.epfl.ch/hpc/coreneuron/-/pipelines/14401 was all green in substance, but a glitch stopped the logs being uploaded and the correct status being reported here. |
Collaborator
|
Logfiles from GitLab pipeline #14425 (:no_entry:) have been uploaded here! Status and direct links:
|
olupton
approved these changes
Aug 20, 2021
Contributor
olupton
left a comment
There was a problem hiding this comment.
Looking good. I quickly looked through the whole diff.
As far as I know, the CI pipelines are all "really" passing, but we're having some GitLab issues...
Update comment in allocate_data_in_mechanism_nrn_init() Change DEBUGQUEUE to CORENRN_DEBU_GQUEUE Update mod2c to latest master
pramodk
reviewed
Aug 20, 2021
Collaborator
|
Logfiles from GitLab pipeline #14438 (:no_entry:) have been uploaded here! Status and direct links:
|
alexsavulescu
approved these changes
Aug 20, 2021
Collaborator
|
Logfiles from GitLab pipeline #14444 (:white_check_mark:) have been uploaded here! Status and direct links:
|
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Aug 20, 2021
…same as NEURON only (#1192) * See the corresponding change in CoreNEURON: BlueBrain/CoreNeuron@c432c13 * This change implements following improvements for CoreNEURON usage: - CoreNEURON direct mode does not do its own version of finitialize(). - On entry to CoreNEURON, all state needed to continue a simulation is copied from NEURON (including Event Queue). - On exit from CoreNEURON all state needed to continue the simulation in NEURON is copied from CoreNEURON (including EventQueue) * Implementation for copying event queue back to NEURON. * Updated testcorenrn with more test: neuronsimulator/testcorenrn#5 * Updated coreneuron submodule: BlueBrain/CoreNeuron#528 * Update rst documentation for the new change * Increase error verbosity for CI debugging. * h.nrnmpi_init() must be called early to avoid mpi error on exit. * Add more tests for net_move, net_send and watch statements * Add tests for neuron<->coreneuron alternate execution * Test of multiple activated WATCH statements. - Note: only one can be triggered at a time. * psolve transfer corenrn -> nrn calls bbcore_read in nrn. - This is needed at least to update nrnran123 sequence state in order to be able to continue psolve on either side. Updated coreneuron and testcorenrn. * Global methods to set and get HOC Random123 sequence. int nrn_random123_setseq(Rand* r, uint32_t seq, char which); int nrn_random123_getseq(Rand* r, uint32_t* seq, char* which); Update external/coreneuron Extend a couple tests for psolve. * Spike transfer from CoreNEURON should append to spike vectors. Begin extending tests involving psolve with CoreNERUON to verify that psolve is restartable. * Framework for copying event queue back to NEURON. * Event Queue NEURON->CoreNEURON NetCon, Presyn, SelfEvent Co-authored-by: Alexandru S�<83>vulescu <[email protected]> Co-authored-by: Michael Hines <[email protected]> Co-authored-by: Olli Lupton <[email protected]> Co-authored-by: Pramod Kumbhar <[email protected]> Closes #1066 Closes #826
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…same as NEURON only (BlueBrain/CoreNeuron#528) * This means: - CoreNEURON direct mode does not do its own version of finitialize(). - On entry to CoreNEURON, all state needed to continue a simulation is copied from NEURON (including Event Queue). - On exit from CoreNEURON all state needed to continue the simulation in NEURON is copied from CoreNEURON (including EventQueue) * Implementation for copying event queue back to NEURON. * This pull request is associated with neuronsimulator/nrnBlueBrain/CoreNeuron#1192 * Improve GPU TrajectoryRequests support: any variable (voltage, imembrane or any mechanism data) can be recorded now. * Add extra #pragma acc wait while recording values from GPU - drop update_{fast_imem,voltage}_from_gpu() methods, those values are now copied by the generic trajectory handling. - add comment explaining why this version may be quite slow, and how it can be improved. * Updated nmodl to latest master to fix the various issues (CPU & GPU) * Check the overflow of NetSendBuffer_t from GPU execution - See rationale for this change in BlueBrain/mod2c/pull/68 - Update the mod2c submodule for CI to pick change of BlueBrain/mod2c/pull/68 * Fixed NEURON_BRANCH setting issue in the CI * Update PatternStim for direct mode. No special treatment except share Info Fixes BlueBrain/CoreNeuron#416 Co-authored-by: Alexandru S�<83>vulescu <[email protected]> Co-authored-by: Michael Hines <[email protected]> Co-authored-by: Olli Lupton <[email protected]> Co-authored-by: Pramod Kumbhar <[email protected]> Co-authored-by: Ioannis Magkanaris <[email protected]> Co-authored-by: Nicolas Cornu <[email protected]> CoreNEURON Repo SHA: BlueBrain/CoreNeuron@c432c13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParallelContext.psolve(tstop) behavior for CoreNEURON direct mode is same as NEURON only.
This means CoreNEURON direct mode does not do its own version of finitialize().
On entry to CoreNEURON, all state needed to continue a simulation is copied from NEURON (including Event Queue).
On exit from CoreNEURON all state needed to continue the simulation in NEURON is copied from CoreNEURON (including EventQueue)
This pull request is associated with neuronsimulator/nrn#1192
Fixes #416
How to test this?
Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=psolve-direct,
Todos: