This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Cleaning netpar.cpp #385
Merged
Cleaning netpar.cpp #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@nrnhines : do you agree that removing |
Collaborator
|
I have no objection to removing them. They are just counts and as such are available from NEURON. |
pramodk
approved these changes
Aug 21, 2020
Collaborator
pramodk
left a comment
There was a problem hiding this comment.
LGTM! thanks getting rid of the unused code!
pramodk
reviewed
Aug 28, 2020
| void unlock() {} | ||
|
|
||
| // Lockable | ||
| bool try_lock() {} |
Collaborator
There was a problem hiding this comment.
@alkino : missed here :
utils/nrnmutdec.h:159:26: warning: control reaches end of non-void function
[-Wreturn-type]
bool try_lock() {}
pramodk
added a commit
that referenced
this pull request
Sep 21, 2020
- changing base class method prototype result into bug for
virtual method in PlayRecordEvent
pramodk
added a commit
that referenced
this pull request
Sep 21, 2020
* Bug fix for PR #385 : add missing `const` for virtual method - changing base class method prototype result into bug for virtual method in PlayRecordEvent * Additional improvements with override for virtual functions
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Clean netcon / netpar implementation * Remove NRNSTATS * Clean macros needed for OMPMutex by providing empty implementation * Put override on overrided methods CoreNEURON Repo SHA: BlueBrain/CoreNeuron@1e3a3a2
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…tual method (BlueBrain/CoreNeuron#394) * Bug fix for PR BlueBrain/CoreNeuron#385 : add missing `const` for virtual method - changing base class method prototype result into bug for virtual method in PlayRecordEvent * Additional improvements with override for virtual functions CoreNEURON Repo SHA: BlueBrain/CoreNeuron@1a3bfa3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.