Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@nrnhines
Copy link
Collaborator

Fixes Ivan's last problem mentioned in #369.

@nrnhines nrnhines requested a review from pramodk August 18, 2020 11:18
@nrnhines
Copy link
Collaborator Author

nrnhines commented Aug 18, 2020

Oops. I inadvertently committed as well my private change to the spike output format.
Reverted that line.

@nrnhines
Copy link
Collaborator Author

nrnhines commented Aug 18, 2020

The errors on the default pipeline are

[ERROR] No output files. Test failed!

Not clear to me why this change caused that.

Seems bizarre. But without knowing what went wrong, could instead clear_spike_vectors on entry from NEURON. It does seem that output_spikes_parallel will not write a file if there are no spikes. (Whereas output_spikes_serial does write an empty file.)

@pramodk
Copy link
Collaborator

pramodk commented Aug 18, 2020

Not clear to me why this change caused that.

I believe { } were missing to the if statement. Fixes that now.

@pramodk pramodk merged commit cfefe0a into master Aug 18, 2020
@pramodk pramodk deleted the clear-spike-vectors branch August 18, 2020 15:41
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants