This repository was archived by the owner on Mar 20, 2023. It is now read-only.
GPU build improvements for NEURON integration #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MPI C++ bindings are removed from MPI - avoid linking mpi c++ library for simplicity - print mpi c/c++ compiler
- create property CORENEURON_LIB_LINK_FLAGS with necessary LDFLAGS
to link coreneuron with neuron via nrnivmodl
- suppress additional PGI warnings which are not necessary to emit
with old mod2c
- minor change in nrn_setup.hpp : functions declarated as static
in the header result into warning as definitions are in .cpp file
8586b59 to
2214a82
Compare
2214a82 to
cb5ed7f
Compare
Collaborator
Author
|
Also include #372, should be merged after that. |
alexsavulescu
approved these changes
Aug 17, 2020
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Update README with latest workflow
* Avoid linking to C++ MPI libraries
- MPI C++ bindings are removed from MPI
- avoid linking mpi c++ library for simplicity
- print mpi c/c++ compiler
* Improvemenets for GPU build integration with NEURON
- create property CORENEURON_LIB_LINK_FLAGS with necessary LDFLAGS
to link coreneuron with neuron via nrnivmodl
- suppress additional PGI warnings which are not necessary to emit
with old mod2c
- minor change in nrn_setup.hpp : functions declarated as static
in the header result into warning as definitions are in .cpp file
* Update weights from GPU before copying to NEURON
CoreNEURON Repo SHA: BlueBrain/CoreNeuron@dca1dc0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to link coreneuron with neuron via nrnivmodl
with old mod2c
in the header result into warning as definitions are in .cpp file