Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@nrnhines
Copy link
Collaborator

@nrnhines nrnhines commented Aug 4, 2020

Framework in place along with comment describing the data structures.

This interacts with BlueBrain/mod2c#43 and neuronsimulator/nrn#695 and they need to be built together.

Framework in place along with comment describing the data structures.
@nrnhines nrnhines requested a review from pramodk August 4, 2020 01:09
@nrnhines nrnhines marked this pull request as draft August 4, 2020 01:10
@pramodk
Copy link
Collaborator

pramodk commented Aug 6, 2020

@nrnhines : the CI failures are caused by this line :

#define type _type

@nrnhines
Copy link
Collaborator Author

This has been tested with a mod file with a printf statement that prints all the external events arriving at the NET_RECEIVE block and processing the stdout with

$ cat test/coreneuron/test.sh
#!/bin/bash

nrniv -python test_fornetcon.py | sed -n '/zzz/s/^.*zzz //p'|uniq|sed '1d'> temp
sed -n '1,/INITIAL/p' < temp > temp1
sed '1,/INITIAL/d' < temp > temp2
sortspike temp1 temp
mv temp temp1
sortspike temp2 temp
mv temp temp2
diff temp1 temp2

(The uniq part of the filter converts the 10 lines from the INITIAL block from printf("zzz INITIAL\n") to just one line in order to conveniently separate the output of NEURON from the output of CoreNEURON).

Anyway, a better test would be for CoreNEURON to send back the weights to NEURON at the end of the run (just like the spikes) and then it will be easy to integrate the test into nrn/test/coreneuron for automatic testing.

Til then, I think it would be best to go ahead and merge this into the master as CoreNEURON is undergoing major refactoring that causes conflict with this branch.

@nrnhines nrnhines marked this pull request as ready for review August 11, 2020 12:00
@nrnhines nrnhines requested a review from alexsavulescu August 11, 2020 12:07
Copy link
Contributor

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few suggestions.

@alexsavulescu
Copy link
Contributor

@pramodk we should see about stopping running jenkins jobs when PR gets updated (save some time)

Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit 3eda428 into master Aug 12, 2020
@pramodk pramodk deleted the fornetcon branch August 12, 2020 22:02
@pramodk
Copy link
Collaborator

pramodk commented Aug 12, 2020

@pramodk we should see about stopping running jenkins jobs when PR gets updated (save some time)

thats true! Seems like there are some solutions.

pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
* Framework to support FOR_NETCONS construct with CORENEURON.
* Update correct mod2c master with necessary support
* Implement setup_fornetcon_info
* Remove _type redefine macro to avid issues with compile like GCC v8.3
* docs target are not added if coreneuron is used as submodule
* After embedded simulation, copy weights back to NEURON NetCon.

Co-authored-by: Alexandru Savulescu <[email protected]>
Co-authored-by: pramodk <[email protected]>

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@3eda428
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants