-
Notifications
You must be signed in to change notification settings - Fork 41
FOR_NETCON #355
Conversation
Framework in place along with comment describing the data structures.
|
@nrnhines : the CI failures are caused by this line : CoreNeuron/coreneuron/nrnoc/md1redef.h Line 62 in f2e0f01
|
|
This has been tested with a mod file with a printf statement that prints all the external events arriving at the NET_RECEIVE block and processing the stdout with (The Anyway, a better test would be for CoreNEURON to send back the weights to NEURON at the end of the run (just like the spikes) and then it will be easy to integrate the test into nrn/test/coreneuron for automatic testing. Til then, I think it would be best to go ahead and merge this into the master as CoreNEURON is undergoing major refactoring that causes conflict with this branch. |
alexsavulescu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few suggestions.
|
@pramodk we should see about stopping running jenkins jobs when PR gets updated (save some time) |
pramodk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thats true! Seems like there are some solutions. |
* Framework to support FOR_NETCONS construct with CORENEURON. * Update correct mod2c master with necessary support * Implement setup_fornetcon_info * Remove _type redefine macro to avid issues with compile like GCC v8.3 * docs target are not added if coreneuron is used as submodule * After embedded simulation, copy weights back to NEURON NetCon. Co-authored-by: Alexandru Savulescu <[email protected]> Co-authored-by: pramodk <[email protected]> CoreNEURON Repo SHA: BlueBrain/CoreNeuron@3eda428
Framework in place along with comment describing the data structures.
This interacts with BlueBrain/mod2c#43 and neuronsimulator/nrn#695 and they need to be built together.