This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Return all spikes vectors to NEURON #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could generate the out.dat if the callback is nullptr or if the callback does not copy the spikes (and so returns 0(?)) |
Collaborator
I am thinking similar : if coreneuron is running in embedded mode then don't generate the spike output file. Otherwise LGTM |
pramodk
reviewed
Aug 3, 2020
53b233f to
a7979eb
Compare
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Return all spikes vectors to NEURON * don't write out.dat if NEURON gets spike vectors CoreNEURON Repo SHA: BlueBrain/CoreNeuron@f2e0f01
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In link with: neuronsimulator/nrn#692
Should we add an extra parameter to the NEURON callback in order to indicate if writing
output.datshould be skipped? Or is something we'd like to have at a global level, say a CLI option?