Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Add --verbose option Closes #338 #341

Merged
pramodk merged 6 commits into from
Aug 8, 2020
Merged

Add --verbose option Closes #338 #341

pramodk merged 6 commits into from
Aug 8, 2020

Conversation

@alexsavulescu
Copy link
Contributor

@alexsavulescu alexsavulescu commented Jul 16, 2020 •
edited
Loading

Sample output when launched from NEURON:

Starting CoreNEURON data generation
Starting CoreNEURON simulation
 Additional mechanisms from files
 Ca.mod CaDynamics_DC0.mod CaDynamics_E2.mod Ca_HVA.mod Ca_HVA2.mod Ca_LVAst.mod CoreConfig.mod Ih.mod Im.mod K_Pst.mod K_Tst.mod KdShu2007.mod NaTa_t.mod NaTg.mod NaTs2_t.mod Nap_Et2.mod ProbAMPANMDA_EMS.mod ProbGABAAB_EMS.mod ProfileHelper.mod SK_E2.mod SKv3_1.mod TTXDynamicsSwitch.mod VecStim.mod cacumm.mod cacummb.mod cagk.mod cal2.mod can2.mod cat.mod gap.mod h.mod halfgap.mod kadist.mod kaprox.mod kca.mod kd.mod kd2.mod kdb.mod kdrbca1.mod kdrca1.mod km.mod kmb.mod na3n.mod naxn.mod netstim_inhpoisson.mod new_calcium_channels.mod


 WARNING: nrn_nrn_wrote_conc support on GPU need to validate!

 psolve |========================================================| t: 50.00  ETA: 0h00m20s

Solver Time : 19.8974

@pramodk I would still keep the mechanisms (as they could be different ones?) and solver information.

@alexsavulescu alexsavulescu marked this pull request as draft July 16, 2020 14:20
@alexsavulescu alexsavulescu linked an issue Jul 16, 2020 that may be closed by this pull request
Add --verbose flag for CLI to control output messages #338
Closed
@alexsavulescu alexsavulescu changed the title Add --quiet option #338 Add --verbose option Closes #338 Jul 20, 2020
@alexsavulescu alexsavulescu marked this pull request as ready for review July 21, 2020 07:39
@pramodk
Copy link
Collaborator

pramodk commented Jul 25, 2020

@pramodk I would still keep the mechanisms (as they could be different ones?) and solver information.

sorry for delay here. In case of none, there should be really no output from coreneuron.

@alexsavulescu
Copy link
Contributor Author

alexsavulescu commented Jul 28, 2020

@pramodk I would still keep the mechanisms (as they could be different ones?) and solver information.

sorry for delay here. In case of none, there should be really no output from coreneuron.

Looks like that is never the case:

https://github.com/BlueBrain/CoreNeuron/blob/master/coreneuron/mechanism/mech/mod_func.c.pl#L28

@alexsavulescu alexsavulescu requested a review from pramodk July 31, 2020 13:28
@alexsavulescu
Copy link
Contributor Author

alexsavulescu commented Aug 4, 2020

With last commit all output is skipped if verbose==0

pramodk
pramodk approved these changes Aug 8, 2020
View reviewed changes
Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit 7ff03a4 into master Aug 8, 2020
@pramodk pramodk deleted the be_quiet branch August 8, 2020 10:37
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
@alexsavulescu
Add --verbose option Closes BlueBrain/CoreNeuron#338 (BlueBrain/CoreN…
da08ac0 
…euron#341)

* Add verbose option
* Disable brew update to speedup builds
* Use Xcode 11.3 for travis OSX CI

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@7ff03a4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pramodk pramodk pramodk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add --verbose flag for CLI to control output messages

3 participants

@alexsavulescu @pramodk