Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@WeinaJi
Copy link

@WeinaJi WeinaJi commented Feb 13, 2020

No description provided.

@alkino alkino mentioned this pull request Feb 13, 2020
18 tasks
@WeinaJi WeinaJi marked this pull request as ready for review February 14, 2020 08:49
@WeinaJi WeinaJi requested review from alkino and ohm314 February 14, 2020 08:49
Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, but maybe a little more can be added into the PR?

@alkino
Copy link
Member

alkino commented Feb 18, 2020

Please retest

@pramodk pramodk merged commit a0ce316 into master Feb 19, 2020
@pramodk pramodk deleted the useboolean branch February 19, 2020 23:08
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
* clean code: Use bool instead of int wherever possible
* Keep old api for fuctions used by Neuron
* change use_interleave_permute to interleave_permute_type

Co-authored-by: Nicolas Cornu <[email protected]>
Co-authored-by: Pramod Kumbhar <[email protected]>

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@a0ce316
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants