Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@alkino
Copy link
Member

@alkino alkino commented Feb 13, 2020

No description provided.

@bbpbuildbot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!
Just one question regarding nrnivmodl_core_makefile.

@pramodk
Copy link
Collaborator

pramodk commented Feb 14, 2020

I believe I/we have made (very small) changes to PGI, Fujitsu and Cray compiler headers. We need review those before merging those.

@alkino : if you look at git log of features directory, it should be there?

@pramodk
Copy link
Collaborator

pramodk commented Feb 17, 2020

Please retest

@alkino alkino force-pushed the Random123_submodule branch from b3d0857 to bfe2c5c Compare February 19, 2020 16:38
@alkino alkino changed the base branch from remove_dead_code to master February 19, 2020 16:38
@pramodk
Copy link
Collaborator

pramodk commented Feb 20, 2020

Please retest

@pramodk pramodk merged commit 42da29d into master Feb 21, 2020
@pramodk pramodk deleted the Random123_submodule branch February 21, 2020 09:06
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
* Add Random123 as a submodule and remove files
* Get patches from BBP for Random123
* Install Random123 to include directory as it required for nrnivmodl-core

Co-authored-by: Pramod Kumbhar <[email protected]>

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@42da29d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants