This repository was archived by the owner on Mar 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Random123 as a submodule #258
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
This was referenced Feb 13, 2020
ohm314
reviewed
Feb 13, 2020
Contributor
ohm314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Just one question regarding nrnivmodl_core_makefile.
Collaborator
|
I believe I/we have made (very small) changes to PGI, Fujitsu and Cray compiler headers. We need review those before merging those. @alkino : if you look at git log of |
Collaborator
|
Please retest |
b3d0857 to
bfe2c5c
Compare
…here; update nrnivmodl_core_makefile.in to avoid using Random123 from source
Collaborator
|
Please retest |
pramodk
approved these changes
Feb 21, 2020
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Add Random123 as a submodule and remove files * Get patches from BBP for Random123 * Install Random123 to include directory as it required for nrnivmodl-core Co-authored-by: Pramod Kumbhar <[email protected]> CoreNEURON Repo SHA: BlueBrain/CoreNeuron@42da29d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.