Fix tests CMA #406
Fix tests CMA #406
Conversation
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 41 41
Lines 2473 2473
=======================================
Hits 2238 2238
Misses 235 235 Continue to review full report at Codecov.
|
tox.ini
Outdated
| flake8 | ||
| mock | ||
| neuron-nightly | ||
| neuron |
There was a problem hiding this comment.
I'd prefer keep on testing on nightly though, to find issues as early as possible
There was a problem hiding this comment.
I think we just found an issue then :D
There was a problem hiding this comment.
There was a problem hiding this comment.
Is it something we have to report to the nrn github ?
There was a problem hiding this comment.
Probably best. This is an error generator by a neuron header file, right?
There was a problem hiding this comment.
The issue is coming from this line:
There was a problem hiding this comment.
Ah Pramod answered: neuronsimulator/nrn#1875
There was a problem hiding this comment.
As mentioned in the BBP internal slack channel, assuming this StochKv3.mod from BBP, I would copy the updated version from BBP models (e.g. here)
Would be happy to help if anything else is required.
Edit: And would recommend keep using neuron-nightly so that we can find issues earlier and fix them in advance (on neuron side as well!) :)
99ac27f to
9a473b0
Compare
|
I see that there are quite a few changes in examples/l5pc/mechanisms/ProbAMPANMDA_EMS.mod and GABA. I think we don't use these files? Maybe it's better to just remove these from the repo |
|
Same for stochkv and stochkv3, we probably only use 1 of these? Best to remove the one we don't use. |
|
We use both in the examples/stochkv |
|
Ok, but not the synapse files i assume, right? |
|
Yes, I removed these |
| assert abs(log.select("avg")[-1] - 40.) < 1e-4 | ||
| assert abs(log.select("std")[-1] - 16.32993) < 1e-4 | ||
| assert pop[0] == [0.09601241274168831, 0.024646650865379722] | ||
| assert abs(pop[0][0] - 0.09601241274168831) < 1e-6 |
There was a problem hiding this comment.
No description provided.