Skip to content

Conversation

@pranavjain97
Copy link
Contributor

Ticket: WP-4760

@mohammadalfaiyazbitgo
Copy link
Contributor

Remember to regenerate the open api specs

@pranavjain97 pranavjain97 marked this pull request as ready for review June 25, 2025 22:05
@pranavjain97 pranavjain97 force-pushed the WP-4760-send-many-mpc-eddsa branch from 2c25873 to 7863ca6 Compare June 25, 2025 22:06
@pranavjain97 pranavjain97 enabled auto-merge June 25, 2025 22:06
@pranavjain97 pranavjain97 force-pushed the WP-4760-send-many-mpc-eddsa branch from 7863ca6 to f9a2617 Compare June 25, 2025 22:12
Copy link
Contributor

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments but nothing blocking.

throw new Error('txRequestId missing from signed transaction');
}

if (signedTxRequest.apiVersion === 'full') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's default to full

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and not support lite

@pranavjain97 pranavjain97 force-pushed the WP-4760-send-many-mpc-eddsa branch from 1fbb223 to 9504aa1 Compare June 26, 2025 20:23
@pranavjain97 pranavjain97 force-pushed the WP-4760-send-many-mpc-eddsa branch from de859d5 to badf21f Compare June 26, 2025 20:31
@pranavjain97 pranavjain97 merged commit 2a5094f into master Jun 27, 2025
3 checks passed
@pranavjain97 pranavjain97 deleted the WP-4760-send-many-mpc-eddsa branch June 27, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants